helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
30 stars 9 forks source link

Show filled trash can icon if items are inside #154

Open probonopd opened 1 year ago

probonopd commented 1 year ago

Actually there is already code for that in Filer in placesmodel.cpp and it does show the filled trash can icon in non-Spatial mode in the sidebar of windows, but we also want this behavior here

image

But ideally we could do without trash:///, gvfs, Glib, and all of that. Just by finding out which directory the trashed items are kept in, and setting a QFileSystemWatcher on that. (Currently the icon on the desktop is just a .desktop file, that should go too.

Our stretch goal is to get rid of libfm and Glib eventually, so let's do this the Qt way.

PaulMcClernan commented 1 year ago

Hey I'd like to contribute, I'm a graphic artist by trade, into coding and MIDI stuff by night, and currently working at trying to maintain a FOSS xTalk (HyperCard-like) script language. Is there a list of Icons you will be needing for 'Network' or External USB (Orange icon?) drives or whatever? Is

probonopd commented 1 year ago

Hi @PaulMcClernan, thanks for chiming in.

Starting from user-trash.svg, do you think you could make a bulging one, maybe similar to the below but with the lid off?

image

PaulMcClernan commented 1 year ago

if you toggle between the two they should align I suppose I could fatten the full can so there's a bulge to further convey 'full'

PaulMcClernan commented 1 year ago

user-trash-closed

PaulMcClernan commented 1 year ago

user-trash-full2

PaulMcClernan commented 1 year ago

I can convert to .icns format too if various px size bitmaps are still needed. Personally if it can do vector drawing and not be too laggy on limited hardware then I think SVG is the way to go, rather than generating a bunch of 1024x1024, 512x512,256x256, etc. bitmaps that eat hard disk space.

probonopd commented 1 year ago

Thank you very much @PaulMcClernan. Highly appreciated. If you'd like to contribute some more icons and the various size bitmaps, we should consider opening a dedicated repository for the icons. Wdyt?

PaulMcClernan commented 1 year ago

I'm totally interested in contributing more graphics work, install testing (I have a variety of hardware I can test on), and work on a scripting engine (got to have some 'AppleScript-like' scripting right?) , also probably want to learn Python / PyQt soon, so maybe I could help in that area at some point. I'm not completely unfamiliar with Python. Maybe I could use PythonCard (https://pythoncard.sourceforge.net/walkthrough2.html) hah!

I'm particularly interested in the QML bits of Qt as that could be useful with the OpenXTalk project, I'm interested in combining a JVM xTalk called OpenXION with PyQt for UI objects, and possibly use QML as Git-friendly GUI mark-up for use in representing xTalks stack/card/stackOjects/etc metaphor and then re-generate the UI from the ML via a parsing script. The OXT engine's ancestor (MetaCard) actually began its life on Unix, so it would be fitting if it could run there again (and on a Mac-like BSD to boot!) in some form at least. Ubuntu compatibility layer at least should work. OpenXION on the other hand could run anywhere there's a JVM (or maybe even without a JVM installed by using GraalVM natifier). Could maybe even use GNUStep for Cocoa-like objects via StepTalk? ....sorry rambling on there.

probonopd commented 1 year ago

@PaulMcClernan would be great to chat with you! :+1:

probonopd commented 1 year ago

Opened https://github.com/helloSystem/Artwork. Let's continue the discussion of needed pieces of artwork at https://github.com/helloSystem/Artwork/issues. Thanks!