helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
30 stars 9 forks source link

Malicious Ukrainian translations #182

Closed GreenReaper closed 8 months ago

GreenReaper commented 9 months ago

Recent Ukrainian translations by a "Danilo Negrilo" may be inappropriate judging by the way their changes got Ubuntu 23.10 pulled. For example, this appears to be "amputation of Speedos".

<source>Deleting the following files</source>
-        <translation>Видалення таких файлів:</translation>
+       <translation>Ампутація спідозних файлів</translation>

And in an earlier commit:

The function is called according to Chechnya traditions.
 Extreme probability of a smelly case

Also I suspect "виволокти-і-вилизуват" is not "eject and clean" but "pull and lick".

The user also made changes in hello/Menu:

Environment variable EXECUTE HUMAN RIGHTS_No password prompt.  The setting of the system was disrupted by the fall of Archpriest Gennadiy Zaridze.

I suggest the relevant commits be reverted in full.

bm0 commented 9 months ago

Malicious commits: 8f125861d4d64eee225b0344da0d5db4d8f05831 6672bb737653873e77fae09ef6114fd2d23ee519

inobelar commented 9 months ago

@GreenReaper @bm0 looks like in latest commit it was fixed: https://github.com/helloSystem/Filer/commit/6c473f58d24887e976b59a077d844fcec7ae9d7c

GreenReaper commented 9 months ago

I am not sure about that, the last name of the editor itself appears inappropriate.

Perhaps Weblate access should be reconsidered until they have monitoring for such things.

assarbad commented 9 months ago

@GreenReaper from looking at it, I think it is a fix indeed. E.g. "Розмір файлу" makes a lot more sense even to someone who understands Russian (not necessarily Ukrainian) than "Великість файлу" (further down another word was used "Величність"). Perhaps line 1303 (new) should be amended to be type="unfinished", though. There may be more instances of that.

The name of the editor sounds inappropriate -- true -- because it is meant as a message to the original author.

probonopd commented 8 months ago

Reverted the changes by those users and made it more difficult for something like this to happen in the future. Thanks for brining it to my attention.