helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
32 stars 8 forks source link

Filer sidebar consistency with the sidebars of other applications #31

Open grahamperrin opened 3 years ago

grahamperrin commented 3 years ago

Spun off from https://github.com/helloSystem/ISO/issues/121#issuecomment-770388224

Generally, aim for consistency across applications so (for example) volumes that appear in the sidebar of Filer should also appear in the sidebar of Image Viewer:

image

… Filer should not define its own bookmarks but to use those from the Qt File Open/Save dialog. And I tend to agree. …

probonopd commented 3 years ago

This is where the Qt ones from the File open/save dialog are apparently stored:

FreeBSD% cat ~/.config/QtProject.conf 
[FileDialog]
(...)
shortcuts=file:, file:///home/user, file:///home/user/Desktop
(...)

This is where apparently Filer bookmarks currently end up being saved:

FreeBSD% cat /home/user/.config/gtk-3.0/bookmarks
file:///Applications Applications
file:///Applications/Utilities Utilities
file:///Applications/Preferences Preferences
file:///home/user/Downloads Downloads
file:///usr/home/user/testcase testcase

That FIler saves stuff in a Gtk place is of course unwanted.

probonopd commented 3 years ago

Reported upstream at https://github.com/lxqt/libfm-qt/issues/698.

probonopd commented 3 years ago

Right now, the bookmarks in the file manager are in sync with the bookmarks in Gtk file open/save dialogs:

image

But NOT in sync with the bookmarks in Qt file open/save dialogs:

image

Maybe it would be best to save the bookmarks in both locations, for Gtk and Qt applications.

But upstream has closed the ticket unfortunately.

probonopd commented 3 years ago

Upstream will not fix this because apparently https://github.com/lxqt/lxqt-qtplugin overrides their Qt file open/save dialogs with custom versions that use the Gtk bookmarks. Getting rid of Gtk is apparently not their goal, but it is ours.

So we will have to do implement it on our own. Volunteers?