helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
31 stars 9 forks source link

Dragging a mountpoint to the Trash should unmount/eject #50

Closed probonopd closed 1 year ago

probonopd commented 3 years ago

Related to https://github.com/helloSystem/Filer/issues/41

Whenever the user tries to move a folder to the Trash, check whether something is mounted at that location(s), and ask the user whether that volume should be ejected/unmounted. In no case move a directory that has something mounted to it to the Trash!

What shall happen if a combination of files, folders and mountpoints is dragged by the user to the Trash? (What happens on a Mac in this case)?

probonopd commented 3 years ago

What shall happen if a combination of files, folders and mountpoints is dragged by the user to the Trash? (What happens on a Mac in this case)?

Dragging to the trash to eject

Moving things to the Trash

probonopd commented 1 year ago

Implemented in a simple form: If at least one of the items dragged to the trash is a mountpoint, then we try to unmount all dragged items. If someone wants to implement a more fancy form as described above, feel free to do it.