Order items on the desktop, volumes should always be first

helloSystem / Filer

A file manager that can also render the desktop

GNU General Public License v2.0

30 stars 9 forks source link

Order items on the desktop, volumes should always be first #60

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

This is a follow-up from https://github.com/helloSystem/Filer/issues/9.

Would it be possible to adjust the order a bit?

Ideally:

The "File System" icon (/, URL computer:///root.link) should always be the first one
Followed by any other disks (MIME type inode/mount-point, URL computer:///*.mount) ideally in the order of time when they were mounted (oldest mounts first)
Everything else, depending on the order set by the user

cc @moochris

ghost commented 3 years ago

Yeah, should be possible - I should have a bit more time next weekend to look at this and a few other things

ghost commented 3 years ago

I realise I have just fixed the default ordering with that PR (which previously was modified date/time)

I don't really know how you would order the devices first in combination with the sort order chosen by the user.

probonopd commented 3 years ago

Thanks for looking into this. Merging your PR, but it's not completely solved yet: Depending on what sort order the user chooses (e.g, by file type, by file name) it still can happen that the volumes are not in front of everything else.

To be clear, the intended behavior is that only the files and folders to be afftected by the sort order the user chooses. The combined model should not be sorted according to the user's choice. Volumes should always be first, and always in the order of when they were mounted.

probonopd commented 3 years ago

Thanks @moochris for having resolved this issue. :+1: