search

helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
30 stars 9 forks source link

Bookmark reordering fails #63

Closed grahamperrin closed 3 years ago

grahamperrin commented 3 years ago

From https://github.com/helloSystem/Filer/issues/9#issuecomment-808908297:

attempting to move a bookmark

  1. drag
  2. drop

Expected:

  1. drop in the required place

Actual result:

  1. bounce back to the wrong place.
probonopd commented 3 years ago

Cannot reproduce: Reordering bookmarks works for me on helloSystem build: 0E57 for commit: 80061bf.

computer:/// is not a concept we want to have. Using URLs rather than paths in Filer feels "alien", like if it is coming from Gnome. Why would you want that bookmark anyway, the items from "Computer" are under "Devices". Or are you missing the Startvolume /? That's actually something that should be added under "Devices"... but that's a different issue.

grahamperrin commented 3 years ago

Today I can't reproduce the issue, but it feels very fiddly.

When I encountered the issue, it's wasn't just fiddly. I tried repeatedly (for a couple of minutes) to drop in a suitable place, it didn't work.

Postscript: today's test was probably limited to a live boot (not the installed system); there were only three bookmarks.

probonopd commented 3 years ago

Please comment in case you can reproduce it on the unedited Live ISO or unchanged installed system.

grahamperrin commented 3 years ago

"alien", like if it is coming from Gnome.

I don't use GNOME.

Is there to be prevention of bookmarks?

grahamperrin commented 3 years ago

There's certainly a bug, probably upstream.

Part of the problem is the plus icon appearing where it should not appear. Bad UX.

probonopd commented 3 years ago

Is there to be prevention of bookmarks?

No. But the use of URLs for anything but the web might change in favor of Unix paths in the future.