search

helloSystem / Filer

A file manager that can also render the desktop
GNU General Public License v2.0
30 stars 9 forks source link

Add "Move to Trash" menu item #96

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

Add "Move to Trash" menu item. Shortcut: Ctrl-Backspace (gets mapped to Alt-Backspace on helloSystem by default).

probonopd commented 3 years ago

The Edit menu currently has an item that always says "Delete", even if Filer is set up to put things into the Trash rather than directly delete them.

The context menu that appears when you right-click a file or folder does this correctly.

Here is the code in question:

https://github.com/helloSystem/Filer/blob/bce6e515fdbe6a14482825a5dd1a2f6d3cd64834/libfm-qt/filemenu.cpp#L362-L370

But this does not get reflected in the Edit menu item. It should.

probonopd commented 3 years ago

Shortcut is now implemented, but it still always says "Delete" rather than "Move to Trash". Bug?

kettle-7 commented 3 years ago

Says 'Move to Trash' for me...

probonopd commented 3 years ago

In the context menu (only) or also in the main menu?