search

helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
808 stars 58 forks source link

/etc/rc.conf is not correctly transferred to the installed system #201

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

Describe the bug /etc/rc.conf on the installed system is missing some entries.

Presumably

https://github.com/helloSystem/ISO/blob/f1a84b6df2ad474a28d06d9f193b0d984734cafd/overlays/uzip/furybsd-live-settings/files/usr/local/bin/furybsd-install#L183-L184

is not working correctly?

To Reproduce Steps to reproduce the behavior:

  1. Install helloSystem to disk
  2. Check /etc/rc.conf

Expected behavior All settings from https://github.com/helloSystem/ISO/blob/experimental/settings/rc.conf.common are there in the installed system.

Version (please complete the following information):

Additional context https://github.com/helloSystem/Utilities/issues/37#issuecomment-812584946

probonopd commented 3 years ago

Questions to @pkgdemon:

probonopd commented 3 years ago

Had to rollback 32f8310 and 32f8310 because they resulted in Xorg being broken.

probonopd commented 3 years ago

https://github.com/helloSystem/ISO/commit/e738d386750d8acf6c57c5f6cd4d94f93bf1e838 closes this.

pkgdemon commented 3 years ago

Questions to @pkgdemon:

  • Why does build.sh put things into /etc/rc.conf.local but then the installer script does not carry over the things in /etc/rc.conf.local to the installed system?
  • Why not only use /etc/rc.conf, why also do things in /etc/rc.conf.local?

@probonopd Sorry for delay. Here are answers...

1.) I believe I did that for two reasons. First this command needed to generate variables required for a default install with zfs bsdinstall config will wipe rc.conf https://github.com/helloSystem/ISO/blob/experimental/overlays/uzip/furybsd-live-settings/files/usr/local/bin/furybsd-install#L77. Secondly I wanted user configured settings to carry over.

2.) I added rc.conf.local so I could have special settings only for the livecd that would not be part of install.