helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
808 stars 58 forks source link

Autostart broken when Welcome.app runs #221

Open probonopd opened 3 years ago

probonopd commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Run the Live ISO
  2. Icons for volume etc. are missing in the menu bar

Expected behavior Icons for volume etc. (launched by /Applications/Autostart) are missing in the menu bar

Version (please complete the following information):

Reference: https://github.com/helloSystem/ISO/issues/220#issuecomment-863516074

kettle-7 commented 3 years ago

In /usr/local/bin/start-hello:

if [ -e /System/Welcome.app/Welcome ] ; then
  if [ ! -e "${HOME}/.config/hello/.helloSetupDone" ] ; then
    /System/Welcome.app/Welcome
  fi
fi

No ampersand to tell it to start in the background.

I'm not entirely sure if that is the problem or if something else is, but I'd assume so.

kettle-7 commented 3 years ago

Wait...

If that was the issue then you'd have no menubar or desktop icons.