helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
806 stars 58 forks source link

Missing Icons #332

Closed daniel-lemke closed 2 years ago

daniel-lemke commented 2 years ago

Describe the bug I have noticed icons missing in a few areas:

To Reproduce

  1. Boot from LiveCD or installed system
  2. Go to the affected areas

Expected behavior Icons to be present.

Screenshots If applicable, add screenshots to help explain your problem. Print Settings Screen Settings Dock Missing Icons

Version (please complete the following information):

probonopd commented 2 years ago

Print Settings and Screen Settings are (still) Gtk applications and we don't ship the Adwaita Gtk icon theme. The plan is to eventually replace those applications with system native Qt applications.

So I never actually cared about those. But now that you say it... the fix is actually easy:

Just add gtk-icon-theme-name=elementary-xfce to the following files:

Missing icons in the Dock are a separate and entirely unrelated issue. Please open a ticket in https://github.com/helloSystem/Dock on this if one doesn't already exist.

Thank you very much!

probonopd commented 2 years ago

Missing icons in Print Settings and Screen Settings should be fixed in the next build. Please comment here in case they aren't.