helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
805 stars 58 forks source link

Stock Redshift does not load custom configuration #366

Open Slater91 opened 2 years ago

Slater91 commented 2 years ago

Describe the bug Redhisft comes with the system, but it is not configurable. Its default colour temperatures are 6500 for the day and 5500 for the night, which I find unsuitable. I have created a configuration file which works perfectly well if I start Redshift manually, but which appears to be ignored by the instance that starts automatically with the system.

To Reproduce Steps to reproduce the behavior:

  1. Create a redshift.conf file in your home directory (/home/user/.config/redshift.conf)
  2. Reboot

Expected behavior The redshift.conf file is read and settings are subsequently applied.

Version (please complete the following information):

Computer (please complete the following information):

probonopd commented 2 years ago

Currently redshift is started as part of the helloDesktop start script /usr/local/bin/start-hello like this:

redshift -t 6500:5500 -l$(getlalo) &

You can change the color temperatures by editing the start-hello script for now.

Do you know how to achieve what redshift -t 6500:5500 -l$(getlalo) & achieves by using a config file?

Slater91 commented 2 years ago

I currently don't, but I will look into it. In any case, I think there might be a bigger issue at play here: if "getlalo" works as I think it does, which is by getting latitude and longitude of the city that sets the time zone, then this doesn't work too well if you live far from there. In my own specific case, I live in Scotland, which is hundreds of kilometres north of London and therefore has a noticeably different day-night cycle from the capital, thus using London to set the Redshift cycle doesn't really work that well. What made you decide to use getlalo instead of geoclue? Have you found/explored any other alternatives?

probonopd commented 2 years ago

What made you decide to use getlalo instead of geoclue? Have you found/explored any other alternatives?

It was the first thing that worked for me, but if other options are better then I am happy to consider them!

Slater91 commented 2 years ago

I've taken a look at how the Redshift plasmoid on KDE Plasma is implemented, and apparently they use the Mozilla Location Service. I don't know how much work would be to integrate this into helloSystem, I'll take a look and report my findings.