helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
805 stars 58 forks source link

rc.conf.common: kld_list: fusefs, not fuse #400

Closed grahamperrin closed 1 year ago

grahamperrin commented 1 year ago

man 5 fusefs

SYNOPSIS

https://www.freebsd.org/cgi/man.cgi?query=fusefs&sektion=5&manpath=FreeBSD#SYNOPSIS

probonopd commented 1 year ago

If I remember correctly, the name changed in some FreeBSD version. Hence, iirc, we are also loading FUSE it in start-hello just to be sure. Is it currently not working somewhere?

grahamperrin commented 1 year ago

Is it currently not working somewhere?

If I recall correctly, failure to load was amongst the first things that caught my eye, at system startup time, with a fresh installation of 0.7.0, after I ceased to mute things.

The rename occurred more than three years ago:

https://github.com/freebsd/freebsd-src/commit/123af6ec70016f5556da5972d4d63c7d175c06d3

grahamperrin commented 1 year ago

Sorry, I didn't realise that renaming a branch is treated as deletion for PR purposes.

probonopd commented 1 year ago

Sorry, I didn't realise that renaming a branch is treated as deletion for PR purposes.

I didn't know that either.

Let me fix that build error which is my fault, then we can merge this.

grahamperrin commented 1 year ago

Ready to merge?

probonopd commented 1 year ago

Both checks failed, not quite sure why.

probonopd commented 1 year ago

Re-ran, FreeBSD 13 build succeeded; 14 still broken thanks to missing emulators/virtualbox-ose-additions (unrelated to this PR). Merged. Thanks @grahamperrin