Rename 'localize' package (GNUstep installs when not requested)

darkoverlordofdata commented 1 year ago

Describe the bug When running pkg upgrade, GNUstep is installed

To Reproduce Install helloSystem sudo pkg update sudo pkg upgrade

Expected behavior I expect only programs already installed to be upgraded

Version (please complete the following information): On both 0.7.0 and 0.8.0_0H89 FreeBSD 13.0 and Freebsd 13.1 https://github.com/helloSystem/ISO/releases/tag/r0.7.0 https://github.com/helloSystem/ISO/releases/tag/experimental-13.1 not on vm

Computer (please complete the following information): Dell Inspiron 3521

Additional context This originall happened on 0.7.0. While tring to repro, additional upgrades rendered the system unusable. When I switched to 0.8.0, I installed Chromium, and this triggered an upgrade, and I ended up with both Chromium and GNUstep. I've reproed this by going straight to pkg upgrade.

probonopd commented 1 year ago

We need to find out what is causing this. @grahamperrin had posted commands for getting this information from pkg somewhere but I can't seem to find them right now...

grahamperrin commented 1 year ago

can't seem to find

Keywords, for search purposes, were debug verbosity

For the answer to not be lost again: https://github.com/helloSystem/hello/discussions/383

grahamperrin commented 1 year ago

From https://github.com/helloSystem/ISO/issues/399#issuecomment-1251868767, saved to a text file (easier to digest):

barsoomian 2022-09-20.txt

grahamperrin commented 1 year ago

installed 2022-09-17
I'll restore a snapshot from 2022-09-12 (pictured below), maybe find an explanation.

The snapshot from 2022-09-12 included a log of the packages installed on the previous day, so I'm restoring and starting an earlier snapshot:

grahamperrin commented 1 year ago

To Reproduce Install helloSystem …

That's the origin of the issue.

pkg info localize

Note that textproc/localize dependencies include x11-toolkits/gnustep-back.

Check overlays/uzip/localize/manifest and/or settings/overlays.hello in https://github.com/helloSystem/ISO/commit/04c5d294e36cbd80a4ab4573f733c8ef3402ed2a.

There'll be an easier way to discover the origin of the issue, after an upgrade, but for the record – prior to upgrade:

mowa219-gjp4-hello-070% sudo su -
root@mowa219-gjp4-hello-070:~ # pkg info -x gnustep
pkg: No package(s) matching gnustep
root@mowa219-gjp4-hello-070:~ # /bin/csh
root@mowa219-gjp4-hello-070:~ # pkg -ddd upgrade -n > & /tmp/pkg-upgrade-debuglevel3.txt 
root@mowa219-gjp4-hello-070:~ # grep -B 1 gnustep /tmp/pkg-upgrade-debuglevel3.txt | less
Checking for upgrades (270 candidates)...
DBG(3)[8896]> Pkg: add a new dependency origin: x11-toolkits/gnustep-back, name: gnustep-back
--
DBG(3)[8896]> added shlib deps for localize on libobjc.so.4.6
DBG(3)[8896]> added shlib deps for localize on libgnustep-gui.so.0.28
DBG(3)[8896]> added shlib deps for localize on libgnustep-base.so.1.27
DBG(3)[8896]> Pkg: add a new dependency origin: x11-toolkits/gnustep-back, name: gnustep-back
--
DBG(3)[8896]> added shlib deps for localize on libobjc.so.4.6
DBG(3)[8896]> added shlib deps for localize on libgnustep-gui.so.0.28
DBG(3)[8896]> added shlib deps for localize on libgnustep-base.so.1.27
--
DBG(3)[8896]> Pkg: add a new dependency origin: x11-toolkits/libXmu, name: libXmu
DBG(3)[8896]> Pkg: add a new dependency origin: x11-toolkits/gnustep-gui, name: gnustep-gui
--
DBG(3)[8896]> Pkg: add a new dependency origin: lang/libobjc2, name: libobjc2
DBG(3)[8896]> Pkg: add a new dependency origin: lang/gnustep-base, name: gnustep-base
--
DBG(3)[8896]> Pkg: add a new dependency origin: graphics/cairo, name: cairo
DBG(3)[8896]> added shlib deps for gnustep-back on libobjc.so.4.6
DBG(3)[8896]> added shlib deps for gnustep-back on libgnustep-gui.so.0.28
DBG(3)[8896]> added shlib deps for gnustep-back on libgnustep-base.so.1.27
DBG(3)[8896]> added shlib deps for gnustep-back on libfreetype.so.6
DBG(3)[8896]> added shlib deps for gnustep-back on libfontconfig.so.1
DBG(3)[8896]> added shlib deps for gnustep-back on libcairo.so.2
DBG(3)[8896]> added shlib deps for gnustep-back on libXt.so.6
DBG(3)[8896]> added shlib deps for gnustep-back on libXrender.so.1
root@mowa219-gjp4-hello-070:~ #

– lines such as these:

DBG(3)[8896]> added shlib deps for localize on libgnustep-gui.so.0.28

grahamperrin commented 1 year ago

Probable workaround, prior to upgrade, where `localize` is preinstalled

pkg delete localize

Hint

pkg query -e '%o = local' %n

probonopd commented 1 year ago

So it seems like our localize package (which has nothing to do with textproc/localize port gets overridden by the latter package.

Possibly we need to rename our localize package then.

Thanks @grahamperrin for finding this out, very helpful.

grahamperrin commented 1 year ago

From #399 (comment), …

Equally, this from @darkoverlordofdata could have been a clue:

Installed packages to be UPGRADED:
        localize: 0 -> 0.0.1_11 [FreeBSD]

exact version 0 of anything should raise an eyebrow.

grahamperrin commented 1 year ago

From https://github.com/helloSystem/ISO/issues/404#issuecomment-1257006266:

… an easier way to discover the origin of the issue, after an upgrade, …

Visually

$ pkg_tree -r gnustep-back
gnustep-back-0.28.0_1
 \__ localize-0.0.1_11
$

https://github.com/helloSystem/ISO/pull/406

Textually

Based on pkg-query(8) EXAMPLES:

root@mowa219-gjp4-hello-070:~ # pkg query %ro gnustep-base
x11-toolkits/gnustep-back
x11-toolkits/gnustep-gui
root@mowa219-gjp4-hello-070:~ # pkg query %ro gnustep-back

textproc/localize
root@mowa219-gjp4-hello-070:~ #

grahamperrin commented 1 year ago

Now, check that https://github.com/helloSystem/ISO/commit/a2e91945eb26ceae0c600c2efe9cf6ae13017070 will not cause problems for users who will install x11/gnustep-app …

grahamperrin commented 1 year ago

https://github.com/helloSystem/ISO/issues/404#issue-1383068016

… additional upgrades rendered the system unusable. …

that is https://github.com/helloSystem/ISO/issues/399

… installed Chromium, and this triggered an upgrade, …

that is expected, if you'd like an explanation please make it a question in Q&A at https://github.com/helloSystem/hello/discussions/categories/q-a.

helloSystem / ISO