helloSystem / ISO

helloSystem Live and installation ISO
https://github.com/helloSystem/
BSD 3-Clause "New" or "Revised" License
809 stars 58 forks source link

Users.app in 0.7.0 no longer works after upgrades #405

Open grahamperrin opened 2 years ago

grahamperrin commented 2 years ago

After upgrades (for security etc.), the Users application is no longer usable.

mowa219-gjp4-hello-070% /Applications/Preferences/Users.app/Users 
The Python module 'translate' is not available. The application will run untranslated.
Could not find suitable .ts files in /Applications/i18n
Traceback (most recent call last):
  File "/Applications/Preferences/Users.app/Resources/adduser.py", line 191, in <module>
    widget = Users()
  File "/Applications/Preferences/Users.app/Resources/adduser.py", line 41, in __init__
    self.load_ui()
  File "/Applications/Preferences/Users.app/Resources/adduser.py", line 52, in load_ui
    for e in self.findChildren(QObject, None, Qt.FindChildrenRecursively):
NameError: name 'QObject' is not defined

To Reproduce

  1. install from hello-0.7.0_0G160-FreeBSD-13.0-amd64.iso
  2. upgrade from end-of-life FreeBSD 13.0-RELEASE, to 13.1-RELEASE-p2
  3. pkg delete localize to avoid https://github.com/helloSystem/ISO/issues/404
  4. unlock all packages except hello
  5. upgrade packages
  6. Preferences
  7. Users

Expected

  1. the application.

Screenshots

image

Version (please complete the following information):

Additional context

Switching from quarterly to latest is not a workaround.

grahamperrin commented 2 years ago

NameError: name 'QObject' is not defined

Maybe try something like https://gis.stackexchange.com/a/296346

grahamperrin commented 2 years ago

Partial workaround

adduser(8) remains usable. Integral to FreeBSD.

probonopd commented 2 years ago

Does adding from PyQt5.QtCore import QObject fix this @grahamperrin?

We are using QObject in many Python files: https://github.com/search?l=Python&q=org%3AhelloSystem+QObject&type=Code

grahamperrin commented 2 years ago

adding from PyQt5.QtCore import QObject

How is that done?

probonopd commented 2 years ago

Actually it is already there:

https://github.com/helloSystem/Utilities/blob/3ade80fa42f8aa83253da3edd14516f06446ee9f/Preferences/Users.app/Resources/adduser.py#L10

Strange.