helloSystem / Menu

Global menu bar written in Qt
43 stars 14 forks source link

There is no AM PM in Japanese, only more seconds are displayed #130

Open louies0623 opened 1 year ago

louies0623 commented 1 year ago

Japanese image

In japanese AM = 午前 PM = 午後 aAdqu Japanese_time

Korean image

Simplified Chinese image

probonopd commented 1 year ago

We are using the locales as defined by Qt. We are not modifying them manually.

https://github.com/helloSystem/Menu/blob/694b4657aa4ab2dfb97c58bd16b5bf2a784527d2/plugin-datetime/datetimewidget.cpp#L39

Do you see any Qt options we would need to use?

louies0623 commented 1 year ago

I'll check first to see if it's a translation problem because it only happens in Japanese.

louies0623 commented 1 year ago

It is not in the translation list, have you added it?

probonopd commented 1 year ago

I have not changed anything, no. So possibly we don't even support Japanese properly yet at this moment.

probonopd commented 1 year ago

Which one is "Japanese" (jp) that most people in Japan use?

image

Stuff like this is what tends to drive me crazy.

Seems like "ja" is what has been used for most projects so far:

https://hosted.weblate.org/projects/hellosystem/menu/ja/

louies0623 commented 1 year ago

is "ja" I reference this project https://translate.ubports.com/languages/ja/ubports/

ja kanji = japanese kanji Non-Japanese everyday expressions Kansai = japanese dialect in Kansai ja_CARES Need to check , Maybe Honorific speech in Japanese jpn_JP Need to check

louies0623 commented 1 year ago

I still have a question, how the date and time are translated, Weblate does not have these translation strings.

probonopd commented 1 year ago

They are not translated (by us) at all. We are just using what Qt provides.

louies0623 commented 1 year ago

Maybe don't use what qt provides, it should be added to Date Time translation.