helloSystem / Menu

Global menu bar written in Qt
44 stars 14 forks source link

Recognize changes in resolution and adapt accordingly #140

Open darkoverlordofdata opened 1 year ago

darkoverlordofdata commented 1 year ago

Dell Inspiron 3521 helloSystem 0.8.0 (Build 0H284)

I have a script in autostart that runs xrandr to connect to an external monitor:

#!/bin/sh 
xrandr --output LVDS-1 --off --output VGA-1 --off --output HDMI-1 --primary --mode 1920x1080 --pos 1920x0 --rotate normal --output DP-1 --off

The problem is that the top menu bar retains the original width from my laptop 1366 rather than display at the width of 1920. Everything else seems aware of the change. It seems like the menu is not picking up the events from xrandr?

I see issue#36, you state “Actually this is the correct behavior - Menu should be displayed on the main screen”, but I’ve disabled the laptop screen:

gathol% xrandr
Screen 0: minimum 320 x 200, current 1920 x 1080, maximum 16384 x 16384
LVDS-1 connected (normal left inverted right x axis y axis)
   1366x768      60.04 +  40.02  
   1280x720      60.00    59.99    59.86    59.74  
   1024x768      60.04    60.00  
   960x720       60.00  
   928x696       60.05  
   896x672       60.01  
   1024x576      59.95    59.96    59.90    59.82  
   960x600       59.93    60.00  
   960x540       59.96    59.99    59.63    59.82  
   800x600       60.00    60.32    56.25  
   840x525       60.01    59.88  
   864x486       59.92    59.57  
   700x525       59.98  
   800x450       59.95    59.82  
   640x512       60.02  
   700x450       59.96    59.88  
   640x480       60.00    59.94  
   720x405       59.51    58.99  
   684x384       59.88    59.85  
   640x400       59.88    59.98  
   640x360       59.86    59.83    59.84    59.32  
   512x384       60.00  
   512x288       60.00    59.92  
   480x270       59.63    59.82  
   400x300       60.32    56.34  
   432x243       59.92    59.57  
   320x240       60.05  
   360x202       59.51    59.13  
   320x180       59.84    59.32  
VGA-1 disconnected (normal left inverted right x axis y axis)
HDMI-1 connected primary 1920x1080+0+0 (normal left inverted right x axis y axis) 476mm x 268mm
   1920x1080     60.00*+  50.00    59.94  
   1920x1080i    60.00    50.00    59.94  
   1680x1050     59.88  
   1600x900      60.00  
   1280x1024     75.02    60.02  
   1280x800      59.91  
   1152x864      75.00  
   1280x720      60.00    50.00    59.94  
   1024x768      75.03    60.00  
   832x624       74.55  
   800x600       75.00    60.32  
   720x576       50.00  
   720x576i      50.00  
   720x480       60.00    59.94  
   720x480i      60.00    59.94  
   640x480       75.00    60.00    59.94  
   720x400       70.08  
DP-1 disconnected (normal left inverted right x axis y axis)
gathol% 

2023-01-24-180328_1920x1080_scrot

probonopd commented 1 year ago

Ah, you are saying the Menu should catch geometry/resolution changes on the fly. Possibly it doesn't do this yet. Of ourse the menu should always span the whole width of the main screen. What is the main screen? The screen the Menu (and Dock) is displayed on.

darkoverlordofdata commented 1 year ago

No, I'm not asking for any changes - this was working as I expect in version 0.7.0 - I just copied my autostart script from the 0.7.0 install. Did the startup sequence change? If it was working, then the autostart scripts must’ve been firing before the top bar was started, and now in version 0.8.0 they fire after the top bar is started? Could that be?

In any case, I wonder if as a workaround I could kill the top bar and restart it? I could add that to the autoexec script.

probonopd commented 1 year ago

killall Menu - it should be restarted automatically after a few seconds.

darkoverlordofdata commented 1 year ago

Yes! That works. Now my desktop is beautiful again :)

probonopd commented 1 year ago

Well, the point it: It should not be neccessary to do this. We need to make it recognize changes in resolution automatically, and adapt accordingly.

probonopd commented 1 year ago

Need to check

https://github.com/SeptemberHX/dde-top-panel/commit/c6ab20e07a930390116dff4865810801e152ab16

darkoverlordofdata commented 1 year ago

This appears to be working now in 8.1. Thanks!