helloSystem / hello

Desktop system for creators with a focus on simplicity, elegance, and usability. Based on FreeBSD. Less, but better!
2.3k stars 57 forks source link

Set hostname in /etc/rc.conf for installed helloSystem #325

Closed SanPollo closed 2 years ago

SanPollo commented 2 years ago

As discussed in this issue, for the installed version of helloSystem, please set the hostname via the hostname option in /etc/rc.conf in order to bring it into line with a standard FreeBSD installation.

More information: hostname(1)

probonopd commented 2 years ago

I suspect that currently we are setting it in /etc/rc.conf.local. Is this any less correct?

SanPollo commented 2 years ago

Personally I set everything in /etc/rc.conf, but there's no reason not to set it in /etc/rc.conf.local according to the man page (although it does mention it exists for "historical reasons").

Anything in rc.conf.local will override whatever is in rc.conf. However, if you decide to keep it in rc.conf.local, please would you remove the hostname="FreeBSD" line from /etc/rc.conf as it is confusing (and is being overridden anyway)?

pynixis commented 2 years ago

@probonopd is the best way to resolve this issue by comment out "hostname="FreeBSD"" in https://github.com/helloSystem/ISO/blob/experimental/settings/rc.conf.common

probonopd commented 2 years ago

We can remove it from https://github.com/helloSystem/ISO/blob/experimental/settings/rc.conf.common#L2 and see what happens...