helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.12k stars 190 forks source link

Fix signature of Bootstrap.__init__() incompatible with older version. #198

Closed davidlesieur closed 2 years ago

davidlesieur commented 2 years ago

The Bootstrap class is now a subclass of Bootstrap4, and provides a deprecation warning. That should prevent existing code from breaking. However, this purpose is defeated by a change in the signature of Bootstrap.__init__() that can break existing code.

This change restores the previous signature.

davidlesieur commented 2 years ago

This matters for existing code that relies on the ability to pass the app object to the init_app() method instead of __init__().

greyli commented 2 years ago

Good catch, thanks!