helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.

https://bootstrap-flask.readthedocs.io

Other

1.12k stars 190 forks source link

Rename parameters of render_nav_item #238

Closed greyli closed 2 years ago

greyli commented 2 years ago

Rename the following parameters of the render_nav_item macro to prevent shadowing the user's URL variables.

badge -> _badge
use_li -> _use_li

fixes: #215

I didn't find the way to emit a deprecate warning in a macro. So this change will release with the 2.1 version directly.

codecov-commenter commented 2 years ago

Codecov Report

Merging #238 (f6c982a) into master (23b2a94) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files           1        1           
  Lines         134      134           
  Branches       23       23           
=======================================
  Hits          130      130           
  Misses          1        1           
  Partials        3        3

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.