helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

render enum in table #271

Closed PanderMusubi closed 1 year ago

greyli commented 1 year ago

Please add some tests for this change and update the changelog.

PanderMusubi commented 1 year ago

Tests are already in https://github.com/helloflask/bootstrap-flask/pull/271/commits/3e5507d1b9773231ee7af0dd5bcfc8ab668ae7ac#diff-5041814f41c9cf2e44c8ee9ec3f448747d7f32492b0d0586f4eda9b7f69a6b27

Update of changes is in https://github.com/helloflask/bootstrap-flask/pull/271/commits/b8f87c9150c7720b364dc5930a639d0ab9fdf837

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +97.01 :tada:

Comparison is base (ef208ca) 0.00% compared to head (b8f87c9) 97.01%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #271 +/- ## =========================================== + Coverage 0 97.01% +97.01% =========================================== Files 0 1 +1 Lines 0 134 +134 Branches 0 17 +17 =========================================== + Hits 0 130 +130 - Misses 0 1 +1 - Partials 0 3 +3 ``` | [Impacted Files](https://codecov.io/gh/helloflask/bootstrap-flask/pull/271?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask) | Coverage Δ | | |---|---|---| | [flask\_bootstrap/\_\_init\_\_.py](https://codecov.io/gh/helloflask/bootstrap-flask/pull/271?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask#diff-Zmxhc2tfYm9vdHN0cmFwL19faW5pdF9fLnB5) | `97.01% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

PanderMusubi commented 1 year ago

@greyli can you review this? Thanks.