helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

modify action_url, view_url, edit_url, delete_url to accept `:id`, similar to how it did in 1.8 #272

Open serensoner opened 1 year ago

greyli commented 1 year ago

Can you add some tests for this change? Also, please add an item to the changelog.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9b066cb) 97.01% compared to head (df8f61b) 97.01%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #272 +/- ## ======================================= Coverage 97.01% 97.01% ======================================= Files 1 1 Lines 134 134 Branches 17 17 ======================================= Hits 130 130 Misses 1 1 Partials 3 3 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

PanderMusubi commented 10 months ago

@serensoner if you can, could you add some tests so we can go forward with this. Thanks.