helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

upgrade bootstrap 5.3.0 #301

Closed PanderMusubi closed 11 months ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ed59d2a) 100.00% compared to head (e47e691) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #301 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 136 136 Branches 16 16 ========================================= Hits 136 136 ``` | [Impacted Files](https://app.codecov.io/gh/helloflask/bootstrap-flask/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask) | Coverage Δ | | |---|---|---| | [flask\_bootstrap/\_\_init\_\_.py](https://app.codecov.io/gh/helloflask/bootstrap-flask/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helloflask#diff-Zmxhc2tfYm9vdHN0cmFwL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

PanderMusubi commented 1 year ago

The default CDN version and integrity values should be updated as well. https://github.com/helloflask/bootstrap-flask/blob/master/flask_bootstrap/__init__.py#L262-L266

Thanks. Will do later today.

PanderMusubi commented 1 year ago

Done, also updated https://github.com/helloflask/bootstrap-flask/discussions/300

PanderMusubi commented 1 year ago

@greyli I see there is also an upgrade of popper from 2.11.6 to 2.11.8. Add that also to this PR?

PanderMusubi commented 1 year ago

@greyli I also see Bootswatch is at 5.3.0 now. I will upgrade that and popper this week and hope we can release soon after that if is okay with you?

greyli commented 1 year ago

I also see Bootswatch is at 5.3.0 now. I will upgrade that and popper this week and hope we can release soon after that if is okay with you?

LGTM.

greyli commented 11 months ago

Merged. I will upgrade Popper and then release 2.3.0.