search

helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

upgrade bootstrap 5.3.1 #308

Closed PanderMusubi closed 11 months ago

PanderMusubi commented 11 months ago

Test in local browser results in these errors when inspecting the HTML in Firefox

None of the “sha384” hashes in the integrity attribute match the content of the subresource. The computed hash is “4bw+/aepP/YC94hEpVNVgiZdgIC5+VKNBQNGCHeKRQN+PtmoHDEXuppvnDJzQIu9”. [127.0.0.1:5000](http://127.0.0.1:5000/)
None of the “sha384” hashes in the integrity attribute match the content of the subresource. The computed hash is “Rx+T1VzGupg4BHQYs2gCW9It+akI2MM/mndMCy36UVfodzcJcF0GGLxZIzObiEfa”.

Please review the three checksums I have upgraded in __init__.py according to this info https://getbootstrap.com/docs/5.3/getting-started/download/#cdn-via-jsdelivr

Not sure how to fix this. Please let me know, so I can improve the upgrade instructions in https://github.com/helloflask/bootstrap-flask/discussions/300

Also don't know if the popperjs checksum needed upgrading.

greyli commented 11 months ago

IMO, we don't need to update the resource so frequently. Just upgrading the major.minor version would be enough. Thanks for working on this though.

The errors are due to incorrect integrity values. You added the files for Bootstrap 5, but you updated the values in the Bootstrap 4 class.

PanderMusubi commented 10 months ago

I agree that major.minor.0 are the most important ones. However, they are usually followed by fixes in a major.minor.1

I see that Bootswatch also has a release for 5.3.1. If I fix the errors and upgrade Bootswatch, would you accept this PR?

greyli commented 10 months ago

OK, sounds good.