search

helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

upgrade bootstrap and bootswatch to 5.3.1 #310

Closed PanderMusubi closed 9 months ago

PanderMusubi commented 10 months ago

Fixing https://github.com/helloflask/bootstrap-flask/pull/308

PanderMusubi commented 9 months ago

Can you merge this one please?

When Bootswatch also has 5.3.2 I want to make another PR https://github.com/twbs/bootstrap/releases/tag/v5.3.2

A bit unrelated, I will also run another example website with the latest development version of Bootstrap-Flask.

greyli commented 9 months ago

When Bootswatch also has 5.3.2 I want to make another PR twbs/bootstrap@v5.3.2 (release)

Merged, thanks!

I plan to remove the built-in JS/CCS resources in 3.0 (it's an unnecessary burden), and support customizing the CDN providers. This seems a better way to go. So I think we don't need to update these libraries.

PanderMusubi commented 9 months ago

I would like to propose that we still include it. I develop literally in planes, trains and automobiles and in countries where I have limited internet.

We could make it that by default the CDN is used for Bootstrap, Bootswatch, Bootstrap Icons, etc. but that there is also an option to use the version that we ship. I'm willing to upgrade tje JS/CSS we ship.