search

helloflask / bootstrap-flask

Bootstrap 4 & 5 helper for your Flask projects.
https://bootstrap-flask.readthedocs.io
Other
1.1k stars 189 forks source link

Version 2.3.2 of Flask breaks examples? #317

Closed PanderMusubi closed 8 months ago

PanderMusubi commented 9 months ago

This line https://github.com/helloflask/bootstrap-flask/blame/02093bf2f6fb415f7a38ba5866e3bf915c1efe2b/requirements/examples.txt#L14 is that the cause of this error:

File "/var/www/html/app.py", line 140, in <module>
  @app.before_first_request
AttributeError: 'Flask' object has no attribute 'before_first_request'

Solution can be to follow the advice of https://stackoverflow.com/questions/73570041/flask-deprecated-before-first-request-how-to-update

PanderMusubi commented 9 months ago

Fixed in https://github.com/helloflask/bootstrap-flask/pull/320

PanderMusubi commented 9 months ago

Merging the PR will enable the live examples demo for HEAD. I will share the URL in https://github.com/helloflask/bootstrap-flask/blob/master/examples/README.rst once it runs again.

PanderMusubi commented 9 months ago

Later improvement needed as noted in https://github.com/helloflask/bootstrap-flask/pull/320#issuecomment-1730552738