helloflask / flask-ckeditor

CKEditor integration for Flask, including image upload, code syntax highlight, and more.
https://flask-ckeditor.readthedocs.io
MIT License
200 stars 67 forks source link

The "Codesnippet" plugin crashes ckeditor with pkg_type= 'basic' #29

Closed AlertRED closed 3 years ago

AlertRED commented 4 years ago

你好! If I install a theme and add a plugin for the code:

class Config(object):
    CKEDITOR_PKG_TYPE = 'basic'
    CKEDITOR_ENABLE_CODESNIPPET = True

then in this case I get this error: image

With _CKEDITOR_PKG_TYPE = 'standart' and 'full'_ all right.

image

greyli commented 4 years ago

Hi, it seems that the Code snippet plugin relay on some plugins that is not included in basic package preset (i.e. Line Utilities and Widget Selection). You can try to build your own CKEdtior basic package to include all the required plugins.

remyzandwijk commented 4 years ago

On the other hand, the Code Snippet plugin is added by us, the package maintainers. So it would make sense that we also include the required plugins.

Edit: it seems that the Code Snippet plugin only require the dialog and widget plugins. Both of them are available in the basic, standard and full package.

remyzandwijk commented 4 years ago

@AlertRED we are going to include the Line Utilities and Widget Selection plugins in the basic package, to make the code snippet plugin work out of the box when using the basic package. It will be in the 0.4.4 release, which should be out soon.

greyli commented 3 years ago

The 0.4.4 version was released on Apr 27, 2020, please upgrade to fix this issue:

pip install -U flask-ckeditor