build CKEditor5 - Githubissues

helloflask / flask-ckeditor

CKEditor integration for Flask, including image upload, code syntax highlight, and more.

https://flask-ckeditor.readthedocs.io

MIT License

197 stars 67 forks source link

build CKEditor5 #57

Closed WebberMao closed 1 week ago

WebberMao commented 2 years ago

Hello, I build CKEditor5 in this RP.

The user can use ckeditor4 or ckeditor5 by choosing different CKEditor class app = CKEditor4(app) #for ckeditor4 app = CKEditor5(app) #for ckeditor5

and change the editor_type (support CKEditor5 only) by setting config `CKEDITOR_EDITOR_TYPE = 'classic' #and all of the following

classic for Classic Editor
inline for Inline Editor
balloon for Balloon Editor
balloon-block for Balloon Block Editor
decoupled-document for Decoupled Editor

hope you will like it!

malikpiara commented 2 years ago

Hi @WebberMao! Super excited to learn CKEditor5 might be available soon! Any news on the merge? Also: Does it make sense to add GitHub sponsors to this project?

greyli commented 1 year ago

Hi, thanks for working on this. I think this PR is still incomplete:

We shouldn't introduce a breaking change directly. The CKEditor class should be kept with a deprecated warning.
The CKEditor5 support for some configurations is not implemented (e.g. CKEDITOR_SERVE_LOCAL, CKEDITOR_LANGUAGE, etc.)
The example application, tests, docs, and changelog should be updated.

greyli commented 1 week ago

Since CKEditor has changed the license to GPL, we decided not to add support to CKEditor 5. Thank you for working on this feature!