search

hellofresh / action-compile-job-status

GitHub Action compiling all job status of a workflow run
Apache License 2.0
0 stars 1 forks source link

Make action compatible with node 20 #10

Closed gmsantos closed 6 months ago

gmsantos commented 6 months ago

Update dependencies and test actions in preparation for a new release compatible with node 20.

klemmster commented 6 months ago

I'm still a bit buffled why this fixes: https://github.com/hellofresh/hf-kubernetes/actions/runs/8617884630/job/23618966950 In theory we're missing the checks:write permission. https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run--fine-grained-access-tokens

gmsantos commented 6 months ago

How did you update the dist?

From local, I ran the steps defined at the workflow in repository:

npm ci
npm run package

I created #11 to track this.

It's a bit strange that the overall lines added is quite big. Looks like tree-shaking might be missing?

We use @vercel/ncc to create the dist script. Unfortunately, it does not support tree-shaking. We could try a different bundler (like rollup) that supports tree-shaking to make the dist package smaller (tracked in #12).