Dry run doesn't care about RUN_MODE

hellofresh / eks-rolling-update

EKS Rolling Update is a utility for updating the launch configuration of worker nodes in an EKS cluster.

Apache License 2.0

361 stars 81 forks source link

Closed netflash closed 3 years ago

netflash commented 3 years ago

Hi there,

I've been using this tool for a while. And recently the dry-run behaviour changed. Unfortunately, I can't say what version introduced this though :-(

I have the RUN_MODE set to 1, but when I run the tool with -p cli key, it runs in RUN_MODE=4.

Expected behaviour: dry run pays attention to the RUN_MODE variable

georambo commented 3 years ago

i've seen the same issue.

pysysops commented 3 years ago

This is fixed by #99

crhuber commented 3 years ago