hellofresh / eks-rolling-update

EKS Rolling Update is a utility for updating the launch configuration of worker nodes in an EKS cluster.
Apache License 2.0
362 stars 80 forks source link

[Feature Request] Detach from ASG or Load Balancer / Target Group #124

Open jgournet opened 2 years ago

jgournet commented 2 years ago

Hi,

This is probably asking for too much, but there might be other people interested: Request: When draining a node from ASG: detach it from the load balancer and/or target group if there's any associated with the ASG.

Alternative: When starting draining a node: could the node be detached from the ASG ? (it sounds simpler, but it probably goes against all the logic of this rolling-update tool)

Why: Our setup has 1 NLB with 1 Target Group, and our nodes run istio ingress gateway as a Daemon Set. Because a Daemon Set is not drained from a node, our ingress gw stays up until the node gets killed, terminating quite abruptly any connection (actually, it's not that brutal, since the ASG itself does the detaching when terminating the node - but that does not give enough time).

Thank you