hellofresh / eks-rolling-update

EKS Rolling Update is a utility for updating the launch configuration of worker nodes in an EKS cluster.
Apache License 2.0
362 stars 80 forks source link

adding option to add extra nodes to each asg #131

Open crosbymichael1 opened 2 years ago

crosbymichael1 commented 2 years ago

When cluster-autoscaler is disabled during the upgrade process this causes new pods being scheduled onto the cluster to be stuck in Pending until the script finishes running and cluster autoscaler is turned back on. Adding additional nodes to the cluster prior to the upgrade can help circumvent this issue and then when cluster auto-scaler is turned back on it can remove unneeded nodes. This is especially needed in Production Cluster where upgrades can take hours and we still want to account for being able to schedule new Pods on the cluster.

crosbymichael1 commented 2 years ago

@crhuber Could I get some eyes on this please. Its something I need as a use case where I work.

crosbymichael1 commented 2 years ago

@chadlwilson are you able to review this please?

chadlwilson commented 2 years ago

I'm not a maintainer here so can't review things. I'm also not actively using eks-rolling-update any longer so not well set up to give useful input and think about how all the options interact with one another.