Code Review

[karlgunst]

Please address the following items

• [x] the user of myBoolean1 is not needed
• [x] The app is only searching for first_name, adjust this to also attempt last_name if the user enters a string with a space (example "John Smith" => first_name=John&last_name=Smith). If the user only enters text with no spaces, assume it is the first name
• [ ] Fix this error : This is caused by invalid use of keyExtractor

  Failed child context type: Invalid child context `virtualizedCell.cellKey` of type `number` supplied to `CellRenderer`, expected `string`

• [ ] there is no error handling on the fetch request. If the request fails the user is shown an infinite loading screen
• [ ] "No Results Found" should not be shown while the query is loading. Move your loading spinner to your display function.
• [x] Fix code formatting, there are some inconsistent indentation

[karlgunst]

@helloish

Please make the following changes:

• add error handling for fetch (https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#checking_that_the_fetch_was_successful)
• No Results Found is still shown when search is loading (Example search for "XYZ123" then search for "John Smith")
• The following error is still shown in the console when running the app

  Unrecognized event: {"type":"client_log","level":"error","data":["Warning: Failed child context type: Invalid child context `virtualizedCell.cellKey` of type `number` supplied to `CellRenderer`, expected `string`.\n    in CellRenderer (at VirtualizedList.js:900)\n    in RCTScrollContentView (at ScrollView.js:1124)\n    in RCTScrollView (at ScrollView.js:1260)\n    in ScrollView (at ScrollView.js:1286)\n    in ScrollView (at VirtualizedList.js:1329)\n    in VirtualizedList (at FlatList.js:624)\n    in FlatList (at App.js:57)\n    in RCTView (at View.js:34)\n    in View (at App.js:82)\n    in App (created by ExpoRoot)\n    in ExpoRoot (at renderApplication.js:45)\n    in RCTView (at View.js:34)\n    in View (at AppContainer.js:106)\n    in DevAppContainer (at AppContainer.js:121)\n    in RCTView (at View.js:34)\n    in View (at AppContainer.js:132)\n    in AppContainer (at renderApplication.js:39)"]}

[helloish]

Here are the issues I have fixed just for your reference:

1. Added error handling on fetch request
2. No Results Found is not shown when query is loading
3. This error does not show up in console anymoreUnrecognized event: {"type":"client_log","level":"error","data":["Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string.\n in CellRenderer (at VirtualizedList.js:900)\n in RCTScrollContentView (at ScrollView.js:1124)\n in RCTScrollView (at ScrollView.js:1260)\n in ScrollView (at ScrollView.js:1286)\n in ScrollView (at VirtualizedList.js:1329)\n in VirtualizedList (at FlatList.js:624)\n in FlatList (at App.js:57)\n in RCTView (at View.js:34)\n in View (at App.js:82)\n in App (created by ExpoRoot)\n in ExpoRoot (at renderApplication.js:45)\n in RCTView (at View.js:34)\n in View (at AppContainer.js:106)\n in DevAppContainer (at AppContainer.js:121)\n in RCTView (at View.js:34)\n in View (at AppContainer.js:132)\n in AppContainer (at renderApplication.js:39)"]}

All the issues you mentioned should be fixed now, please let me know if I am missing anything.