search

helloitszak / bandcamp_volume

A chrome extension to add a volume slider to Bandcamp.com's music player.
31 stars 6 forks source link

Fixes issue #14 with last set volume not getting saved #19

Open bbeng89 opened 7 years ago

bbeng89 commented 7 years ago

For some reason the line (173) that initialized the saveVolume variable had been commented out, so it was never pulling the last saved volume from local storage. Simply uncommenting this seemed to fix the issue.

helloitszak commented 7 years ago

Heyo, thanks for the contribution.

Might be a few days before I can actually merge and test this, but once I can I'll be sure to cut a release.

bbeng89 commented 7 years ago

No problem! I was a little hesitant to just uncomment that line because I thought you probably commented it out for a reason, but I've been using it all day and haven't encountered any issues. Figured it was maybe just a debugging thing that slipped through the cracks.

Anyway, if you find a problem with it just let me know. I don't mind doing the work to fix it. Thanks!

helloitszak commented 7 years ago

You know it's been so long since I seriously touched this code. I'm not sure anymore. I just need to retrace my steps, hopefully I'll remember what the heck I was thinking at the time.

bbeng89 commented 7 years ago

Any word on this?

helloitszak commented 7 years ago

I'm still here and I haven't forgotten. Personal life is just a little bit in the way right now. I promise I'll get to this soon.

Thanks for your patience.

bbeng89 commented 7 years ago

No worries, I totally understand. Just wanted to check in. Thanks!