search

hellonico / origami

Lowest barrier of entry to Image Processing, Computer Vision and Neural Networks on the JavaVM
https://hellonico.github.io/origami-docs/#/
Eclipse Public License 1.0
122 stars 7 forks source link

update to opencv 4.0.1 #27

Closed pekeler closed 5 years ago

pekeler commented 5 years ago

Can we please update to 4.0.1? I'm currently running into https://github.com/opencv/opencv/issues/12963 with 4.0.0.

hellonico commented 5 years ago

Which platform are you running on ? There's a need to recompile all supported platform so we could start with a POC on your targeted environment.

pekeler commented 5 years ago

MacOS 10.14.3

hellonico commented 5 years ago

I've released a preview for 4.0.1 just for OSX. Could you help by writing a test for it ?

hellonico commented 5 years ago

http://repository.hellonico.info/#browse/browse:hellonico:origami%2Forigami%2F4.0.1-0

hellonico commented 5 years ago

I compiled and build is passing on linux too: https://travis-ci.org/hellonico/origami

Could you check ? :)

pekeler commented 5 years ago

Thank you! I’m afraid haven’t touched Java in 12 years and am both a Clojure and OpenCV noob (just picked computer vision as a subject to learn Clojure). I’ll see if I can figure out how to use the new jar tomorrow...

hellonico commented 5 years ago

haha Well just the sample code you were trying to run will be ok then ... I'll figure out how to add it as a test case.

pekeler commented 5 years ago

I ported https://docs.opencv.org/4.0.1/d5/d6f/tutorial_feature_flann_matcher.html to Clojure. https://gist.github.com/pekeler/5eddaae3523426aa147192a130783c56.

It works as expected with 4.0.1 on MacOS. With 4.0.0 it fails on line 41 (RuntimeException: Unable to find static field: DrawMatchesFlags_NOT_DRAW_SINGLE_POINTS). Even after substituting that constant with the int 2, it fails with IllegalArgumentException: No matching method: drawMatches.

Note that originally I ported https://docs.opencv.org/4.0.0/d5/d6f/tutorial_feature_flann_matcher.html but that version has the same two problems with 4.0.0.

hellonico commented 5 years ago

now to 4.1.1 so closing this.