hellosign / hellosign-dotnet-sdk

A .NET SDK for the HelloSign API
MIT License
26 stars 29 forks source link

Signature Request does not support Custom Fields #111

Open RPM1984 opened 3 years ago

RPM1984 commented 3 years ago

The PostSignatureRequest method does not appear to support custom fields, like the template version does.

Both should support this, as per the API documentation

I made this change locally and tested it out, and confirmed this worked as expected.

Happy to submit a PR for this change.

Thanks!

erosiec commented 2 years ago

Thanks @RPM1984 , we're looking into this now and will get back to you with an update as soon as possible.

In the meantime, you can workaround this by adding custom fields through the Client.AdditionalParameters Dictionary object.

Here is an example from README.md using custom fields and text tags:

var request = new SignatureRequest();
request.Title = "Sokovia Accords as discussed";
request.Subject = "Sokovia Accords - Please Sign";
request.Message = "Please sign ASAP";
request.AddSigner("tony@starkindustries.com", "Anthony Stark");
request.AddSigner("steverogers_1918@aol.com", "Steven Rogers");
request.AddCc("shield@shield.org");
request.AddFile("sokovia_accords.PDF");
client.AdditionalParameters.Add("custom_fields", "[{\"name\": \"Address\", \"value\": \"123 Main Street\"}, {\"name\": \"Phone\", \"value\": \"555-5555\"}]");
request.UseTextTags = true;
request.HideTextTags = true;
request.TestMode = true;
var response = client.SendSignatureRequest(request);
Console.WriteLine("New Signature Request ID: " + response.SignatureRequestId);
RPM1984 commented 2 years ago

Thanks for the reply @erosiec ! Thanks, didn't know the AdditionalParameters existed. Will keep that in mind for this and future. Looking forward to having this lib updated! :)