search

hellosign / hellosign-java-sdk

A Java SDK for the HelloSign API.
MIT License
13 stars 27 forks source link

Missing formfields TYPE parameterr #102

Closed alexmac05 closed 4 years ago

alexmac05 commented 4 years ago

Please add this parameter (form_fields_per_document TYPE) to the class FormField.

An example to see this in use would be using this endpoint

https://app.hellosign.com/api/reference#create_embedded_unclaimed_draft and using the parameter form_fields_per_document TYPE.

In the Java SDK.

Need this for end to end testing.

It should be added here.... package com.hellosign.sdk.resource.support.types; public enum FieldType { text, signature, initials, checkbox, date_signed; private FieldType() { } }

robbiediaz commented 4 years ago

I need this functionality in an app I'm building as well. Is there any way we can get the pull request merged in @jspaetzel? I saw it was a WIP branch, but what's left to be done on it?

jspaetzel commented 4 years ago

@robbiediaz just need to write a test. I'll make some time and finish this up this week, maybe today.

robbiediaz commented 4 years ago

Awesome, that sounds great! Thanks for getting back to me :)

jspaetzel commented 4 years ago

New release with this added. Should show up on maven shortly. https://github.com/hellosign/hellosign-java-sdk/releases/tag/4.2.2

robbiediaz commented 4 years ago

Thanks @jspaetzel! :D