search

hellosign / hellosign-java-sdk

A Java SDK for the HelloSign API.
MIT License
13 stars 27 forks source link

Added support for additional files to TemplateSignatureRequests #145

Closed epricer closed 2 years ago

epricer commented 3 years ago

The HelloSign REST API has support for TemplateSignatureRequests with additional files appended to the end, as documented here: https://app.hellosign.com/api/reference#send_with_template https://app.hellosign.com/api/reference#send_embedded_signature_request_with_template

These can be added either as files or file urls. This change allows the Java SDK to send the file or file_urls with the TemplateSignatureRequests. Per the API documentation, only one type (file vs. file url) can be specified. This change does not address enforcing that, as it is not enforced in the SignatureRequest class that this is modeled on.

Note that this fixes https://github.com/hellosign/hellosign-java-sdk/issues/81

jspaetzel commented 2 years ago

This looks nice! Thanks for the contribution!

jspaetzel commented 2 years ago

I'll push out a version with this shortly. It'll be 5.2.2