search

hellosign / hellosign-java-sdk

A Java SDK for the HelloSign API.
MIT License
13 stars 27 forks source link

User Agent incorrectly set by Client #156

Closed codylerum closed 2 years ago

codylerum commented 2 years ago

When looking at requests created by the java client in Hello Sign the User Agent is not properly resolved and shows like hellosign-java-sdk/${project.version}

image

codylerum commented 2 years ago

Looks like when this was created the maven build filtered over the /src/main/resources directory

https://github.com/hellosign/hellosign-java-sdk/blob/4a72ae2d3566d612ef3e6a1d21009b28aca2c242/pom.xml#L57

This must not have been carried over when the build was converted to gradle

codylerum commented 2 years ago

@jspaetzel I'm not a gradle guy so this is probably the extent of what I can do. I did a PR but I can't tell if the test suite is actually being run by github actions

jspaetzel commented 2 years ago

Thanks for the PR @codylerum! Next time I or someone on my team makes changes to this SDK I'll be sure to verify this is working the way we're expecting and merge it in before the next release.