search

hellosign / hellosign-java-sdk

A Java SDK for the HelloSign API.
MIT License
13 stars 27 forks source link

add a method to return the created_at value from a signature request #167

Closed codylerum closed 2 years ago

codylerum commented 2 years ago

When doing audits on outstanding signature requests via the API it would be useful to access the created_at value.

The added method returns a java.time.Instant as that would be the best way to return the seconds since epoch and makes it easier for the developer to convert it to a relevant time on their end using the standard java date/time library.

I would be happy to convert the other methods that currently return the old java.util.Date to the modern java.time.Instant

jspaetzel commented 2 years ago

Thanks for the PR. I like the idea of using Instant however I don't want a one-off where we use instant when we're using Date elsewhere. See AbstractResource::getDate for how this is being used.

Thanks for the contribution, I've made a similar change in https://github.com/hellosign/hellosign-java-sdk/pull/179 to provide the same sort of support.

codylerum commented 2 years ago

@jspaetzel Maybe this is something that can be done with a full version rev and convert everything away from the legacy Date API and to the standard modern one.