hellosign / hellosign-python-sdk

A Python SDK for HelloSign's API
MIT License
29 stars 48 forks source link

Add get_data_uri parameter to get_signature_request_file #52

Closed johnnycupcakes closed 4 years ago

johnnycupcakes commented 5 years ago

response = client.get_signature_request_file( signature_request_id='ID', filename='=files.pdf', file_type='pdf', get_data_uri='true'

Results in TypeError: get_signature_request_file() got an unexpected keyword argument 'get_data_uri' Thank you

Framinus commented 5 years ago

This workaround uses the Python Requests Library:

API_KEY = 'YOUR_API_KEY'
SIGNATURE_REQUEST_ID = 'YOUR_SIGNATURE_REQUEST_ID'
URL = 'https://'+API_KEY+':@api.hellosign.com/v3/signature_request/files/'+SIGNATURE_REQUEST_ID
PARAMS = {'get_url': True}
r = requests.get(url = URL, params = PARAMS)
data = r.json()
print(data)
oconnor-sn commented 4 years ago

I believe this issue can be closed due to Merge of #51

@alexmac05 - can you review and confirm

erosiec commented 4 years ago

This will work using Python SDK version 3.8.9 and here is the syntax:

urlResponse = client.get_signature_request_file( signature_request_id='Signature_REQUEST_ID_HERE', response_type='data_uri' )