search

hellosign / hellosign-python-sdk

A Python SDK for HelloSign's API
MIT License
29 stars 48 forks source link

Fix for issue #44 #62

Closed oconnor-sn closed 4 years ago

oconnor-sn commented 4 years ago

Commit based on PR #50 that was never merged. Added code to incorporate functionality for attachments with signer requests

oconnor-sn commented 4 years ago

@martinytodorov - please verify updates.

oconnor-sn commented 4 years ago

Amended the commit and re-pushed @martinytodorov

martinytodorov commented 4 years ago

Hey @oconnor-sn I checked out the branch on my machine and made a few tests. I realized that there are couple of more things that need to be fixed.

  1. You added the attachments to the function _send_signature_request_with_template. You should remove it from there.
  2. Although you added attachments to _send_signature_request, you are not using them in the payload for the request.

Here's some tips you should follow when opening the PRs:

  1. Always test you changes. If you are adding attachments to signature_request/send and signature_request/create_embedded, then you should use the SDK and make test requests to make sure that your changes are working. Here's my test request if you need one.
  2. Use an IDE that can highlight problems for you. That first problem mentioned above is something that my IDE caught. I am using VSCode. image

Let me know if you have any questions.

oconnor-sn commented 4 years ago

@martinytodorov - anything outstanding on this PR?