search

hellosign / hellosign-ruby-sdk

A Ruby SDK for HelloSign's API
MIT License
52 stars 61 forks source link

Bug: Error creation crashing in Client#prepare_files #103

Open DanielDe opened 5 years ago

DanielDe commented 5 years ago

I'm getting a crash when passing an invalid path for the files parameter in create_embedded_signature_request:

ArgumentError: wrong number of arguments (given 1, expected 2..3)
from /Users/danieldehaas/.rvm/gems/ruby-2.4.4@duco/gems/hellosign-ruby-sdk-3.7.7/lib/hello_sign/error.rb:30:in `initialize'

The problem seems to be in these two places:

The Error initializer expects 2 to 3 arguments but is only getting 1.

Thanks!

sikandartariq1 commented 5 years ago

fixed in this pull request #107

Hussainbhatti1 commented 5 years ago

Please merge this fix.

danfstucky commented 4 years ago

It's been over a year, why has this fix not been merged yet? Initializing errors straight up does not work.

johnnycupcakes commented 4 years ago

Thank you for letting me know, pull request #107 has been merged.

syed-mohsin commented 4 years ago

@johnnycupcakes This fix is part of v 3.7.10 which hasn't been released yet. How can i specify this version in my Gemfile?

alexmac05 commented 4 years ago

i'm looking into this and will get back to you. sorry for the delay.

sallyhall commented 3 years ago

107 allows errors to be initialized, but the way errors are initialized here:

a message is passed to the error class, but is interpreted as the status, creating a confusing human readable message.