search

hellosign / hellosign-ruby-sdk

A Ruby SDK for HelloSign's API
MIT License
52 stars 61 forks source link

Faraday deprecation warning #125

Open mjc-gh opened 2 years ago

mjc-gh commented 2 years ago

When calling HelloSign.create_embedded_signature_request

I get these log message:

WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

I believe it comes from here:

https://github.com/HelloFax/hellosign-ruby-sdk/blob/f5b3cb187873d1be7588c6da775012636f8d90a9/lib/hello_sign/client.rb#L159-L163

However I am not sure how to fix it. Any suggestions?

aub commented 2 years ago

This is because the gem isn't specifying the versions of its dependencies at all. I have a fork over here that fixes this, if that helps.

aub commented 2 years ago

Actually I just made a whole new gem over here. The code is exactly the same as this one except that it includes my two PRs from this repo.