hellosiyan / Viewnior

Elegant Image Viewer
https://siyanpanayotov.com/project/viewnior/
GNU General Public License v3.0
319 stars 55 forks source link

Preparation for porting to GTK3 in GTK+ 2, part 2 #101

Closed qarkai closed 3 years ago

qarkai commented 3 years ago
hellosiyan commented 3 years ago

Thank you for your continued support and work, @qarkai! You have found and fixed some small issues like the Combo Box, unused variables, etc :+1: . But I do not understand the change from GdkDrawable to GdkWindow :thinking: GdkWindow references are passed to functions expecting GdkDrawable, like gdk_draw_pixbuf. As far as I understand GdkWindow is a subtype of GdkDrawable, but aren't there any negative effects of passing the "wrong reference"?

Thanks again!

qarkai commented 3 years ago
  1. It's OK to use subclass. Calling function will a) check parent type (subclass pass it), b) use parent type's methods (subclass has them).
  2. GdkDrawable is gone in GTK3.