hellosiyan / Viewnior

Elegant Image Viewer
https://siyanpanayotov.com/project/viewnior/
GNU General Public License v3.0
319 stars 55 forks source link

Port to gexiv2 #113

Closed qarkai closed 2 years ago

qarkai commented 2 years ago

Removing need in c++ compiler.

hellosiyan commented 2 years ago

@qarkai Thank you for your work. Are there other advantages of using gexiv2 over exiv2, apart from removing the dependency on a c++ compiler? I just don't want to replace something with a wrapper of it, as that would introduce another possible point of failure with no added benefits.

Quickly skimmed through the code and found uninitialized GError variables passed to functions, and the "nice names" for the tags were missing. Also seemed like not all tags are showing up, like the camera model for example.

qarkai commented 2 years ago

There is no advantages at all.