hellosiyan / Viewnior

Elegant Image Viewer
https://siyanpanayotov.com/project/viewnior/
GNU General Public License v3.0
320 stars 54 forks source link

Feature request: Select crop region in main image viewer #48

Open alancutter opened 5 years ago

alancutter commented 5 years ago

Selecting a portion of a screenshot to crop is very difficult to do when the crop preview is so small compared with the size of the image. It would be great if cropping could be done in the primary image viewport. screenshot from 2018-10-24 13-41-49

ghost commented 5 years ago

@alancutter As a work-around I can propose you the following patch. It does not implement the feature you want, but makes the crop dialog bigger.

 src/vnr-crop.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/vnr-crop.c b/src/vnr-crop.c
index 76bdd48..98417f8 100644
--- a/src/vnr-crop.c
+++ b/src/vnr-crop.c
@@ -122,7 +122,10 @@ vnr_crop_build_dialog (VnrCrop *crop)
     width = crop->vnr_win->current_image_width;
     height = crop->vnr_win->current_image_height;

-    vnr_tools_fit_to_size_double(&height, &width, 400,400);
+    gint scr_height = gdk_screen_get_height (gtk_window_get_screen (GTK_WINDOW(window)));
+    scr_height -= scr_height * 0.3;
+
+    vnr_tools_fit_to_size_double(&height, &width, scr_height, scr_height * 2);
     crop->width = width;
     crop->height = height;
     crop->zoom = ( width/crop->vnr_win->current_image_width