hellosiyan / Viewnior

Elegant Image Viewer
https://siyanpanayotov.com/project/viewnior/
GNU General Public License v3.0
320 stars 54 forks source link

Sort images by date + fix the scroll mouse bug #7

Closed geplus closed 8 years ago

geplus commented 9 years ago

Hi, I have 2 requestes for Viewnior:

  1. Make able users to switch images by date of creation/modification
  2. The mouse roll don't increase/decrease the zoom level anymore, even if the option is selected. Please fix that.
0xACE commented 9 years ago

I believe you meant to post a issue, and not a pull request.

Drup commented 9 years ago

Issues are disabled in this repo ...

The mouse scroll bug is very annoying. Note that if you change the wheel setting, it actually changes the double click setting under the hood (which is weird, to say the least).

0xACE commented 9 years ago

Oh, sorry I didn't pay attention to that.

The mouse scroll bug is very annoying. Note that if you change the wheel setting, it actually changes the double click setting under the hood (which is weird, to say the least).

@Drup, @geplus: I run my personal fork of this software. And I recall encountering your issue, it seems to be a issue with HAVE_WALLPAPER. I contacted the author a few months ago.

Anyway here is my quick suggestion, this is what I do when i compile:

./autogen.sh
./configure --disable--wallpaper
make

This bug is introcuded in fc0f5cb3baf4601a25e396de917be51b1ce5cb1d

From my bug report:

seems to break the behaviour of double clicking. It loads the settings fine in

vnr_prefs_init(); vnr_prefs_load();

however in uni_image_view_button_press() it seems like

vnr_win->prefs->behavior_click;

is pointing to the wrong data. I'm guessing it resolves to

prefs->behavior_wheel;

rather than

prefs->behavior_click;

according to the authors suggestion you could prolly clean the directory and then you should be able to compile with HAVE_WALLPAPER

Anyway here is his issue tracker: https://bugs.launchpad.net/viewnior

Drup commented 9 years ago

./configure --disable--wallpaper

That woks! Thanks you.

0xACE commented 9 years ago

Anytime, I'll mail the author once more. Maybe he doesn't pay attention to github.

hellosiyan commented 8 years ago

Hey guys, I just committed a fix for the mouse scroll bug.