hellosiyan / Viewnior

Elegant Image Viewer
https://siyanpanayotov.com/project/viewnior/
GNU General Public License v3.0
320 stars 54 forks source link

"Are you sure [..]"-Message contains no text, when deleting a document which contains an "&" in its filename. #73

Closed bitfreak25 closed 2 years ago

bitfreak25 commented 4 years ago

Using Version 1.7 of Arch Linux.

The file will be deleted successfully. So there might be only this missing text block bug.

Result in the command line:

(viewnior:5360): Gtk-WARNING **: 12:48:24.298: Failed to set text from markup due to error parsing markup: Error on line 2: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity ? escape ampersand as &

The relevant code is at about "src/vnr-window.c" line 1605. Maybe using g_markup_escape_text() (as I read) could resolve this but I'm not sure if this is correct. There could be other places in the code with the same error.