hellotham / hello-astro

Hello Astro is a multi purpose Astro starter theme written in Typescript, TailwindCSS and AlpineJS. It supports Markdown and MDX based pages and blog posts.
https://hellotham.github.io/hello-astro
MIT License
158 stars 55 forks source link

This theme just not work with node v19.4.0. Also, has a duplicate MDX entry #2

Closed alejovargas closed 1 year ago

alejovargas commented 1 year ago

❯ pnpm i  WARN  deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead  WARN  deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility Packages: +589 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Packages are hard linked from the content-addressable store to the virtual store. Content-addressable store is at: /Users/alejo/Library/pnpm/store/v3 Virtual store is at: node_modules/.pnpm Progress: resolved 630, reused 589, downloaded 0, added 589, done

dependencies:

devDependencies:

 WARN  Issues with peer dependencies found . ├─┬ @astrojs/mdx 0.11.6 │ └─┬ @mdx-js/rollup 2.2.1 │ ├── ✕ missing peer rollup@>=2 │ └─┬ @rollup/pluginutils 5.0.2 │ └── ✕ missing peer rollup@^1.20.0||^2.0.0||^3.0.0 └─┬ schema-dts 1.1.0 └── ✕ missing peer typescript@>=4.1.0 Peer dependencies that should be installed: rollup@">=2.0.0 <3.0.0 || >=3.0.0 <4.0.0" typescript@>=4.1.0

Done in 12.4s ❯ pnpm run dev

hello-astro@1.0.1 dev /Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro astro dev

[MDX] Now inheriting remark and rehype plugins from "markdown" config. If you applied a plugin to both your Markdown and MDX configs, we suggest removing the duplicate MDX entry. See "extendPlugins" option to configure this behavior. 🚀 astro v1.5.2 started in 473ms

┃ Local http://localhost:3000/hello-astro/ ┃ Network use --host to expose

/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/web-streams-polyfill@3.2.1/node_modules/web-streams-polyfill/dist/polyfill.js:362 throw new TypeError(context + " is not a ReadableStream."); ^

TypeError: First parameter has member 'readable' that is not a ReadableStream. at assertReadableStream (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/web-streams-polyfill@3.2.1/node_modules/web-streams-polyfill/dist/polyfill.js:362:19) at convertReadableWritablePair (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/web-streams-polyfill@3.2.1/node_modules/web-streams-polyfill/dist/polyfill.js:3524:9) at ReadableStream.pipeThrough (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/web-streams-polyfill@3.2.1/node_modules/web-streams-polyfill/dist/polyfill.js:3608:29) at fetchFinale (node:internal/deps/undici/undici:13682:56) at mainFetch (node:internal/deps/undici/undici:13574:9) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

ChristineTham commented 1 year ago

Hi - thanks for posting this issue.

The error is related to an upstream package, and is not part of the source code of this theme, or astro. The theme does build in node 18 - I just checked.

The warning relating to "duplicate MDX entry" is just a precautionary warning - there is no separate MDX and Markdown configs in the config. It has been removed in later versions of astro.

alejovargas commented 1 year ago

Thank you Christine