helloweishi / ostinato

Automatically exported from code.google.com/p/ostinato
GNU General Public License v3.0
1 stars 2 forks source link

VLAN field doesn't have validation (Vlan, SVlan and SVlan/Vlan) #130

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Connect to Ostinato.
2. Select interface within 'Ports Group' tree.
3. Create new stream.
4. Go into the stream.
5. Select Vlan protocol within 'Available Protocols' list.
6. Click on Right Arrow button.
7. Go to 'Protocol Data' tab.
8. Click on Vlan panel.
9. Enter alphabetic, out of range (0-4096), negative number or special chars 
into VLAN field.
10. Verify that invalid values are not acceptable.

Expected results:
VLAN field doesn't accept invalid values.

Actual results:
Alphabetic, out of range (0-4096), negative number and special chars are 
acceptable for VLAN field in Vlan, SVlan and SVlan/Vlan protocols.

Ostinato version: 0.6

OS: Linux 3.11.0-15-generic #25~precise1-Ubuntu 86_64 x86_64 x86_64 GNU/Linux

Original issue reported on code.google.com by developers@plvision.eu on 22 Sep 2014 at 1:07

GoogleCodeExporter commented 9 years ago
At the moment, most of the protocols including vlan, don't really have any 
input validation. While I accept this is a defect, it's low priority to fix 
(let me know if you feel otherwise and why!)

If anyone wants to submit a patch to fix this, I'll be glad to apply to the 
tree.

Original comment by pstav...@gmail.com on 5 Oct 2014 at 7:50